fix(spec): correct two stale file references found in the spec audit#89
Merged
Conversation
Part 1 of the spec-prose drift cleanup (read-only audit found these): - evidence/envelope.spec.yaml: the deferred AC-10 note referenced `api/envelope.go`, which does not exist. The EvidenceEnvelope struct lives in api/transaction.go. Corrected the reference. - agent/handler-port-filepermissions.spec.yaml: described the controller-side handler shim as a deliverable file `internal/agent/remotehandler/remotehandler.go` + scope entry. That package was never created; the shim was implemented as `agentBackedHandler` in internal/engine/engine.go (returned by engine.lookupHandler when an AgentClient is set). Corrected both the deliverable description and the scope entry to the real location. Spec-prose-only; no AC ids or test annotations touched, so coverage is unaffected. specter 119/119. The remaining audit findings (a stale `internal/deadman/` path and ~26 renamed/missing `Locked by Test...` references across ~12 specs) need per-spec judgment and are scoped separately. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part 1 of the spec-prose drift cleanup. Fixes the two confirmed stale file references the read-only audit found:
api/envelope.go(evidence/envelope.spec.yaml, deferred AC-10 note)EvidenceEnvelopeis inapi/transaction.goapi.EvidenceEnvelopeinapi/transaction.gointernal/agent/remotehandler/remotehandler.go(agent/handler-port-filepermissions.spec.yaml, deliverable + scope)agentBackedHandlerininternal/engine/engine.go(vialookupHandler)internal/engine/engine.go: agentBackedHandlerSafety
Spec-prose-only — no AC ids or test annotations touched, so coverage is unaffected. specter 119/119, 0 check warnings.
Not in this PR (scoped separately)
The remaining audit findings need per-spec judgment, not a mechanical edit:
internal/deadman/intimerfd.spec.yaml) whose "shell-based deadman" context I'd be guessing at.Locked by Test…references across ~12 specs where the test was renamed/restructured — and some may be genuine coverage gaps, not just stale prose.Scope for that pass is in the PR thread / my message.
🤖 Generated with Claude Code